[InferDT] MAC-like node dtype output to fp32 if any fp32 operands#230
Merged
jmitrevs merged 1 commit intofastmachinelearning:mainfrom Jan 29, 2026
Merged
Conversation
makoeppel
requested changes
Jan 23, 2026
Collaborator
makoeppel
left a comment
makoeppel
left a comment
There was a problem hiding this comment.
Can you tell us a bit what this PR does?
makoeppel
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds datatype inference for MAC-like operations receiving floating-point inputs: If any of the inputs is a float, the output should be considered a float as well. This also matches the fallback behavior (see https://github.com/fastmachinelearning/qonnx/pull/230/files#diff-80eda79b3e7e45d86e96b0a595e9257bebaac10a420a31b8fd92ca20d35f133dR136), just that for these MAC-like operations we do not end up at the fallback and thus currently won't have datatype annotation with floating-point inputs.